Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse osu!.db #5

Closed
wants to merge 6 commits into from
Closed

Parse osu!.db #5

wants to merge 6 commits into from

Conversation

kiwec
Copy link

@kiwec kiwec commented Sep 30, 2024

This creates some issues, see comments. I won't work on this further so you're free to take over the PR.

Also: consider reloading the db on every start, to be in sync with the game. Right now it's only loaded once, and then never checked again.

@kiwec
Copy link
Author

kiwec commented Sep 30, 2024

One more thing, I just realized I never yield back to the event loop, so the progress bar doesn't get updated. You should await something every so often or the update() calls will be useless.

Also for speed, you could skip bytes that you're not using. Like the stars of every mod of every ruleset for example.

@CaptSiro CaptSiro assigned CaptSiro and unassigned CaptSiro Sep 30, 2024
@CaptSiro
Copy link
Collaborator

CaptSiro commented Sep 30, 2024

I am going to return to this PR after I am done documenting most of the codebase.

return none();
}

return some(path.join(process.env.LOCALAPPDATA, "osu!", "Songs"));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osu!.db is in the "osu!" directory, not in "osu!/Songs"
To be clear, users should select the "osu!" directory not the "Songs" directory

@kiwec
Copy link
Author

kiwec commented Oct 5, 2024

"merged" in #21

@kiwec kiwec closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants